chore(deps): bump @inquirer/prompts from 7.10.1 to 8.5.2 in /cli - #540
Merged
blafourcade merged 2 commits intoJul 31, 2026
Merged
Conversation
Contributor
Author
|
Dependabot can't parse your pnpm-lock.yaml. Because of this, Dependabot cannot update this pull request. |
Bumps [@inquirer/prompts](https://github.com/SBoudrias/Inquirer.js) from 7.10.1 to 8.5.2. - [Release notes](https://github.com/SBoudrias/Inquirer.js/releases) - [Commits](https://github.com/SBoudrias/Inquirer.js/compare/@inquirer/prompts@7.10.1...@inquirer/prompts@8.5.2) --- updated-dependencies: - dependency-name: "@inquirer/prompts" dependency-version: 8.5.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/cli/next/inquirer/prompts-8.5.2
branch
from
July 28, 2026 04:13
52840a4 to
881dfc4
Compare
@inquirer/core 11 (bundled by @inquirer/prompts 8) defers the first render by one setImmediate tick for any stream with a readableFlowing property - added upstream to let real stdin's OS-buffered data flow through readline harmlessly before listeners attach (SBoudrias/ Inquirer.js#1303). Every Readable, including the PassThrough these tests use, has that property, so the deferral now applies to them too. The tests wrote simulated keypresses via process.nextTick, which runs before the deferred setImmediate that registers inquirer's keypress listener - the write lands with nobody listening, and the prompt hangs until the 60s timeout. Switching to setImmediate orders the write after listener registration. Verified: 22/22 pass in this file, matches exactly what CI's cli/Test job flagged (13 failures, all here).
blafourcade
approved these changes
Jul 31, 2026
blafourcade
left a comment
Contributor
There was a problem hiding this comment.
Root cause: inquirer v8 defers first render one setImmediate tick for any Readable input (upstream fix for SBoudrias/Inquirer.js#1303), which now also delays keypress-listener registration for test PassThrough streams. Fixed the affected test file to write simulated keys via setImmediate instead of process.nextTick so they land after listeners attach. CI green.
dependabot
Bot
deleted the
dependabot/npm_and_yarn/cli/next/inquirer/prompts-8.5.2
branch
July 31, 2026 04:02
blafourcade
added a commit
that referenced
this pull request
Jul 31, 2026
* chore(deps): bump @inquirer/prompts from 7.10.1 to 8.5.2 in /cli Bumps [@inquirer/prompts](https://github.com/SBoudrias/Inquirer.js) from 7.10.1 to 8.5.2. - [Release notes](https://github.com/SBoudrias/Inquirer.js/releases) - [Commits](https://github.com/SBoudrias/Inquirer.js/compare/@inquirer/prompts@7.10.1...@inquirer/prompts@8.5.2) --- updated-dependencies: - dependency-name: "@inquirer/prompts" dependency-version: 8.5.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * fix(cli): defer simulated keypresses to match inquirer v8's render cycle @inquirer/core 11 (bundled by @inquirer/prompts 8) defers the first render by one setImmediate tick for any stream with a readableFlowing property - added upstream to let real stdin's OS-buffered data flow through readline harmlessly before listeners attach (SBoudrias/ Inquirer.js#1303). Every Readable, including the PassThrough these tests use, has that property, so the deferral now applies to them too. The tests wrote simulated keypresses via process.nextTick, which runs before the deferred setImmediate that registers inquirer's keypress listener - the write lands with nobody listening, and the prompt hangs until the 60s timeout. Switching to setImmediate orders the write after listener registration. Verified: 22/22 pass in this file, matches exactly what CI's cli/Test job flagged (13 failures, all here). --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Baptiste LAFOURCADE <baptiste.lafourcade@gmail.com>
blafourcade
added a commit
that referenced
this pull request
Jul 31, 2026
* chore(deps): bump @inquirer/prompts from 7.10.1 to 8.5.2 in /cli Bumps [@inquirer/prompts](https://github.com/SBoudrias/Inquirer.js) from 7.10.1 to 8.5.2. - [Release notes](https://github.com/SBoudrias/Inquirer.js/releases) - [Commits](https://github.com/SBoudrias/Inquirer.js/compare/@inquirer/prompts@7.10.1...@inquirer/prompts@8.5.2) --- updated-dependencies: - dependency-name: "@inquirer/prompts" dependency-version: 8.5.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * fix(cli): defer simulated keypresses to match inquirer v8's render cycle @inquirer/core 11 (bundled by @inquirer/prompts 8) defers the first render by one setImmediate tick for any stream with a readableFlowing property - added upstream to let real stdin's OS-buffered data flow through readline harmlessly before listeners attach (SBoudrias/ Inquirer.js#1303). Every Readable, including the PassThrough these tests use, has that property, so the deferral now applies to them too. The tests wrote simulated keypresses via process.nextTick, which runs before the deferred setImmediate that registers inquirer's keypress listener - the write lands with nobody listening, and the prompt hangs until the 60s timeout. Switching to setImmediate orders the write after listener registration. Verified: 22/22 pass in this file, matches exactly what CI's cli/Test job flagged (13 failures, all here). --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Baptiste LAFOURCADE <baptiste.lafourcade@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @inquirer/prompts from 7.10.1 to 8.5.2.
Release notes
Sourced from @inquirer/prompts's releases.
... (truncated)
Commits
bfd8710chore: Publish new release55cc5f3feat: add reusable package lint CLI3af9ed0test(inquirer): capture prompt runner output4381857fix(@inquirer/input): remove stale lint suppression45df331fix(@inquirer/external-editor): harden editor temp filesadef323chore: limit CI token permissionsb43359dchore: Publish new release24ecae2chore: fix yarn.lockb078d97fix: validate package engine compatibility3a49f9fchore(deps-dev): Bump oxfmt in the formatting group (#2143)